Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12025] Experimental V4 Id feature #12026

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Feb 6, 2025

No description provided.

@emeroad emeroad linked an issue Feb 6, 2025 that may be closed by this pull request
@emeroad emeroad added this to the 4.0.0 milestone Feb 6, 2025
@emeroad emeroad force-pushed the #12025_v4_id branch 2 times, most recently from f37bf81 to 1c9ea0d Compare February 7, 2025 02:01
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 52.95170% with 263 lines in your changes missing coverage. Please review.

Project coverage is 33.74%. Comparing base (f2e771b) to head (16f7f1a).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...ain/java/com/navercorp/pinpoint/grpc/HeaderV4.java 0.00% 51 Missing ⚠️
...ain/java/com/navercorp/pinpoint/grpc/HeaderV1.java 35.29% 33 Missing ⚠️
...navercorp/pinpoint/grpc/ClientHeaderFactoryV4.java 0.00% 20 Missing ⚠️
.../com/navercorp/pinpoint/profiler/DefaultAgent.java 0.00% 19 Missing ⚠️
...navercorp/pinpoint/profiler/ObjectNameBuilder.java 0.00% 17 Missing ⚠️
...orp/pinpoint/grpc/server/ServerHeaderReaderV4.java 27.77% 13 Missing ⚠️
...text/provider/grpc/AgentHeaderFactoryProvider.java 42.10% 10 Missing and 1 partial ⚠️
...inpoint/profiler/name/v4/ObjectNameResolverV4.java 77.27% 6 Missing and 4 partials ⚠️
.../pinpoint/grpc/protocol/ProtocolVersionParser.java 16.66% 9 Missing and 1 partial ⚠️
...p/pinpoint/profiler/AgentContextOptionBuilder.java 0.00% 7 Missing ⚠️
... and 21 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12026      +/-   ##
============================================
+ Coverage     33.61%   33.74%   +0.13%     
- Complexity    10431    10507      +76     
============================================
  Files          3759     3778      +19     
  Lines         89625    89915     +290     
  Branches       9522     9564      +42     
============================================
+ Hits          30123    30342     +219     
- Misses        56896    56954      +58     
- Partials       2606     2619      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emeroad emeroad force-pushed the #12025_v4_id branch 2 times, most recently from f144361 to 079577a Compare February 7, 2025 09:23
@emeroad emeroad force-pushed the #12025_v4_id branch 7 times, most recently from 207c692 to 80692ce Compare February 24, 2025 08:11
@emeroad emeroad merged commit 72358bb into pinpoint-apm:master Feb 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experimental V4 Id feature
1 participant