Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11497] Cleanup #11538

Merged
merged 1 commit into from
Oct 2, 2024
Merged

[#11497] Cleanup #11538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...rp/pinpoint/realtime/collector/receiver/grpc/ActiveThreadCountResponseStreamObserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
/**
* @author youngjin.kim2
*/
public abstract class ActiveThreadCountResponseStreamObserver implements StreamObserver<PCmdActiveThreadCountRes> {
public class ActiveThreadCountResponseStreamObserver implements StreamObserver<PCmdActiveThreadCountRes> {

private static final Logger logger = LogManager.getLogger(ActiveThreadCountResponseStreamObserver.class);

Expand Down Expand Up @@ -116,8 +116,12 @@ public void onCompleted() {
}
}

protected abstract long extractSinkId(PCmdActiveThreadCountRes response);
private long extractSinkId(PCmdActiveThreadCountRes response) {
return response.getCommonStreamResponse().getResponseId();
}

protected abstract int extractSequence(PCmdActiveThreadCountRes response);
private int extractSequence(PCmdActiveThreadCountRes response) {
return response.getCommonStreamResponse().getSequenceId();
}

}
12 changes: 1 addition & 11 deletions ...main/java/com/navercorp/pinpoint/realtime/collector/receiver/grpc/GrpcCommandService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,17 +287,7 @@ public void commandActiveThreadLightDump(PCmdActiveThreadLightDumpRes response,
@Override
public StreamObserver<PCmdActiveThreadCountRes> commandStreamActiveThreadCount(StreamObserver<Empty> responseObserver) {
ServerCallStreamObserver<Empty> serverResponseObserver = (ServerCallStreamObserver<Empty>) responseObserver;
return new ActiveThreadCountResponseStreamObserver(serverResponseObserver, this.activeThreadCountSinkRepo) {
@Override
protected long extractSinkId(PCmdActiveThreadCountRes response) {
return response.getCommonStreamResponse().getResponseId();
}

@Override
protected int extractSequence(PCmdActiveThreadCountRes response) {
return response.getCommonStreamResponse().getSequenceId();
}
};
return new ActiveThreadCountResponseStreamObserver(serverResponseObserver, this.activeThreadCountSinkRepo);
}

private <T> void emitMono(T response, StreamObserver<Empty> responseObserver, Publisher<T> sink) {
Expand Down