[#noissue][FE] fix: filtermap scatter to transactionList bug fix #11535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillionaireDY
force-pushed
the
fix-filtermap-scatter-transaction
branch
from
9d6b0a1 to
39a5ae3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11535 +/- ##
============================================
- Coverage 37.06% 37.04% -0.02%
- Complexity 12215 12230 +15
============================================
Files 4035 4041 +6
Lines 98934 99056 +122
Branches 10433 10437 +4
============================================
+ Hits 36667 36700 +33
- Misses 59283 59370 +87
- Partials 2984 2986 +2 ☔ View full report in Codecov by Sentry. |
binDongKim
reviewed
Oct 3, 2024
| @@ -52,7 +52,8 @@ | |||
| }, | |||
| "TRANSACTION_LIST": { | |||
| "SELECT_TRANSACTION": "Select your transaction", | |||
| "TRANSACTION_RETRIEVE_ERROR": "Transaction information is missing<br>Will go to Main" | |||
| "TRANSACTION_RETRIEVE_ERROR": "Transaction information is missing.", | |||
| "TRANSACTION_RETRIEVE_ERROR_DESC": "Currently, there is no data available from the parent tab. Please try again from the parent tab. (If you close this dialog, you will be redirected to the main page.)" | |||
There was a problem hiding this comment.
This message will ever be shown to the user only when they try getting to the transaction-list page via url without dragging the scatter chart from the server-map page. So the meaning of the word parent tab might not be clear to the user. How about suggesting them to start it over from the server-map page?
Suggested change
| "TRANSACTION_RETRIEVE_ERROR_DESC": "Currently, there is no data available from the parent tab. Please try again from the parent tab. (If you close this dialog, you will be redirected to the main page.)" | |
| "TRANSACTION_RETRIEVE_ERROR_DESC": "Please start it over from the server-map page. (If you close this dialog, you will be redirected to the server-map page.)" |
binDongKim
approved these changes
Oct 7, 2024
BillionaireDY
force-pushed
the
fix-filtermap-scatter-transaction
branch
from
93e8348 to
70f2ed9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs that occur when dragging a scatter chart on the filterMap page.