Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Feat global search #11229

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

BillionaireDY
Copy link
Contributor

  • support
    • txid search
    • navigate pages
image

@BillionaireDY BillionaireDY requested a review from binDongKim July 9, 2024 09:31
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.93%. Comparing base (e5afaf9) to head (5225d3f).
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11229      +/-   ##
============================================
- Coverage     36.98%   36.93%   -0.06%     
  Complexity    12053    12053              
============================================
  Files          3984     3994      +10     
  Lines         97932    98057     +125     
  Branches      10422    10417       -5     
============================================
- Hits          36216    36213       -3     
- Misses        58745    58876     +131     
+ Partials       2971     2968       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binDongKim
Copy link
Contributor

binDongKim commented Jul 10, 2024

Check points

  • Search should cover case-insensitive-ly
    • ex) Search servermap doesn't work
  • Rename useService hook as useMenu or useMenuItem
    • Locate the file under the apps/web/src/hooks path
  • Rollback path.ts file location if it's not necessary

@BillionaireDY BillionaireDY force-pushed the feat-global-search branch 2 times, most recently from 8172d00 to 5225d3f Compare July 12, 2024 01:57
@binDongKim binDongKim merged commit b7dc7a8 into pinpoint-apm:master Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants