Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11186] Change retry header key for collector response #11225

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

donghun-cho
Copy link
Contributor

addtitional changes to #11186

@donghun-cho donghun-cho self-assigned this Jul 8, 2024
@donghun-cho donghun-cho linked an issue Jul 8, 2024 that may be closed by this pull request
@donghun-cho donghun-cho added this to the 3.0.1 milestone Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 36.98%. Comparing base (39b0476) to head (ec2ef87).

Files Patch % Lines
.../main/java/com/navercorp/pinpoint/grpc/Header.java 33.33% 4 Missing ⚠️
...iver/grpc/service/SimpleRequestHandlerAdaptor.java 0.00% 1 Missing ⚠️
...pinpoint/grpc/client/retry/RetryHeaderFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #11225   +/-   ##
=========================================
  Coverage     36.98%   36.98%           
- Complexity    12053    12055    +2     
=========================================
  Files          3984     3984           
  Lines         97932    97932           
  Branches      10422    10422           
=========================================
+ Hits          36219    36224    +5     
+ Misses        58742    58739    -3     
+ Partials       2971     2969    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donghun-cho donghun-cho merged commit e5afaf9 into pinpoint-apm:master Jul 8, 2024
3 checks passed
@donghun-cho donghun-cho deleted the grpc_retry_key branch October 31, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change collector response to be gRPC client retries friendly
1 participant