Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11158] Change gRPC hedging to default retransmission policy #11159

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jun 18, 2024

No description provided.

@emeroad emeroad added this to the 3.0.1 milestone Jun 18, 2024
@emeroad emeroad linked an issue Jun 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 8.19672% with 56 lines in your changes missing coverage. Please review.

Project coverage is 37.08%. Comparing base (168f53a) to head (ae2e4f8).

Files Patch % Lines
...ler/sender/grpc/MetadataGrpcHedgingDataSender.java 0.00% 39 Missing ⚠️
...rofiler/sender/grpc/LogResponseStreamObserver.java 0.00% 12 Missing ⚠️
.../provider/grpc/MetadataGrpcDataSenderProvider.java 55.55% 2 Missing and 2 partials ⚠️
...t/profiler/sender/grpc/MetadataGrpcDataSender.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11159      +/-   ##
============================================
- Coverage     37.08%   37.08%   -0.01%     
- Complexity    12004    12006       +2     
============================================
  Files          3948     3949       +1     
  Lines         97299    97323      +24     
  Branches      10383    10386       +3     
============================================
+ Hits          36087    36090       +3     
- Misses        58255    58272      +17     
- Partials       2957     2961       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emeroad emeroad force-pushed the #11158_grpc_hedging branch from ae2e4f8 to f4eb3ed Compare June 18, 2024 09:17
@emeroad emeroad merged commit 7273fd5 into pinpoint-apm:master Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change gRPC hedging to default retransmission policy
1 participant