Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column webhook_send is still used when webhook.enable property is false #9000

Closed
ga-ram opened this issue Jun 30, 2022 · 0 comments · Fixed by #9001, #9002, #9007 or #9008
Closed

Column webhook_send is still used when webhook.enable property is false #9000

ga-ram opened this issue Jun 30, 2022 · 0 comments · Fixed by #9001, #9002, #9007 or #9008
Assignees
@ga-ram
Labels
bug module:web

Comments

@ga-ram
Copy link
Contributor

ga-ram commented Jun 30, 2022

What version of pinpoint are you using?

master

Describe the bug

Column webhook_send is still used when webhook.enable property is false.
If webhook_send column is not added to the alarm table, users can't add alarms with type All.

Expected behavior

AlarmServiceImpl.insertRule() should only be used with webhook.enable=true
AlarmServiceImpl.insertRuleWithWebhooks() is used with webhook.enable=false
ga-ram added a commit to ga-ram/pinpoint that referenced this issue Jun 30, 2022
@ga-ram
[pinpoint-apm#9000] Use insertRuleExceptWebhookSend when webhook.enab…
62e2097 
…le=false
ga-ram added a commit to ga-ram/pinpoint that referenced this issue Jun 30, 2022
@ga-ram
[pinpoint-apm#9000] Backport: Use insertRuleExceptWebhookSend when we…
b834ad7 
…bhook.enable=false
ga-ram added a commit to ga-ram/pinpoint that referenced this issue Jun 30, 2022
@ga-ram
[pinpoint-apm#9000] Backport: Use insertRuleExceptWebhookSend when we…
84a0650 
…bhook.enable=false
@ga-ram ga-ram self-assigned this Jun 30, 2022
This was linked to pull requests Jun 30, 2022
[#9000] Use insertRuleExceptWebhookSend when webhook.enable=false #9001
Merged
[#9000] Backport: Use insertRuleExceptWebhookSend when webhook.enable=false #9002
Merged
ga-ram added a commit that referenced this issue Jul 1, 2022
@ga-ram
[#9000] Use insertRuleExceptWebhookSend when webhook.enable=false
3ff6559
ga-ram added a commit that referenced this issue Jul 1, 2022
@ga-ram
[#9000] Backport: Use insertRuleExceptWebhookSend when webhook.enable…
b396414 
…=false
smilu97 pushed a commit that referenced this issue Jul 1, 2022
@ga-ram
[#9000] Backport: Use insertRuleExceptWebhookSend when webhook.enable…
a05e253 
…=false
ga-ram added a commit to ga-ram/pinpoint that referenced this issue Jul 4, 2022
@ga-ram
[pinpoint-apm#9000] Use updateRuleExceptWebhookSend when webhook.enab…
a238b15 
…le=false
ga-ram added a commit to ga-ram/pinpoint that referenced this issue Jul 4, 2022
@ga-ram
[pinpoint-apm#9000] Use updateRuleExceptWebhookSend when webhook.enab…
6f5b263 
…le=false
@ga-ram ga-ram linked a pull request Jul 4, 2022 that will close this issue
[#9000] Use updateRuleExceptWebhookSend when webhook.enable=false #9007
Merged
ga-ram added a commit to ga-ram/pinpoint that referenced this issue Jul 4, 2022
@ga-ram
[pinpoint-apm#9000] Backport: Use updateRuleExceptWebhookSend when we…
a8924ea 
…bhook.enable=false
@ga-ram ga-ram linked a pull request Jul 4, 2022 that will close this issue
[#9000] Backport: Use updateRuleExceptWebhookSend when webhook.enable=false #9008
Merged
ga-ram added a commit that referenced this issue Jul 4, 2022
@ga-ram
[#9000] Use updateRuleExceptWebhookSend when webhook.enable=false
e4404f2
ga-ram added a commit that referenced this issue Jul 4, 2022
@ga-ram
[#9000] Backport: Use updateRuleExceptWebhookSend when webhook.enable…
18e5a23 
…=false
smilu97 pushed a commit that referenced this issue Jul 8, 2022
@ga-ram
[#9000] Backport: Use updateRuleExceptWebhookSend when webhook.enable…
739a8b0 
…=false
ga-ram added a commit to ga-ram/pinpoint that referenced this issue Jul 25, 2022
@ga-ram
[pinpoint-apm#9000] Backport: Fix incorrect funciton calls when webho…
bed2f6e 
…ok.enable=false
ga-ram added a commit that referenced this issue Jul 26, 2022
@ga-ram
[#9000] Backport: Fix incorrect funciton calls when webhook.enable=false
819734e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ga-ram ga-ram

Labels
bug module:web
Projects
None yet
Milestone
No milestone
1 participant
@ga-ram