-
Notifications
You must be signed in to change notification settings - Fork 23
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
emit warning when worker gracefully exit before finish (#126)
* emit warning when worker gracefully exit before finish * try making tests less flaky * try making tests less flaky * try making tests less flaky * trigger GitHub Actions CI
- Loading branch information
Showing
4 changed files
with
83 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
const { test } = require('tap') | ||
const ThreadStream = require('../index') | ||
const { join } = require('path') | ||
|
||
function retryUntilTimeout (fn, timeout) { | ||
const start = Date.now() | ||
return new Promise((resolve, reject) => { | ||
async function run () { | ||
if (fn()) { | ||
resolve() | ||
return | ||
} | ||
|
||
if (Date.now() - start >= timeout) { | ||
reject(new Error('timeout')) | ||
return | ||
} | ||
setTimeout(run, 10) | ||
} | ||
|
||
run() | ||
}) | ||
} | ||
|
||
test('emit warning when the worker gracefully exit without the stream ended', async function (t) { | ||
const expectedWarning = 'ThreadStream: process exited before destination stream was drained. this may indicate that the destination stream try to write to a another missing stream' | ||
const stream = new ThreadStream({ | ||
filename: join(__dirname, 'to-next.js') | ||
}) | ||
stream.unref() | ||
|
||
let streamWarning | ||
function saveWarning (e) { | ||
if (e.message === expectedWarning) { | ||
streamWarning = e | ||
} | ||
} | ||
process.on('warning', saveWarning) | ||
|
||
const data = 'hello'.repeat(10) | ||
for (let i = 0; i < 1000; i++) { | ||
if (streamWarning?.message === expectedWarning) { | ||
break | ||
} | ||
stream.write(data) | ||
await new Promise((resolve) => { | ||
setTimeout(resolve, 1) | ||
}) | ||
} | ||
|
||
process.off('warning', saveWarning) | ||
t.equal(streamWarning?.message, expectedWarning) | ||
|
||
await retryUntilTimeout(() => stream.worker.exited === true, 3000) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
'use strict' | ||
|
||
const { PassThrough } = require('stream') | ||
|
||
async function run (opts) { | ||
return new PassThrough({}) | ||
} | ||
|
||
module.exports = run |