Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: formatOpts typo #422

Merged
merged 2 commits into from
Jun 2, 2018
Merged

fix: formatOpts typo #422

merged 2 commits into from
Jun 2, 2018

Conversation

davidmarkclements
Copy link
Member

@davidmarkclements davidmarkclements commented May 29, 2018

search and replace gone awry

So the impact of this not saying formatOpts means that {lowres: true} was not being passed to quick-format-unescape which means any log messages that interpolate an object with a circular will say 'text content "[Circular]"' instead of 'text content {"path": {"to": "[Circular]"}}'

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test?

@davidmarkclements
Copy link
Member Author

looked into this further: the correct behaviour should actually be to set lowres in formatOpt according to the safe option. This won't change the default behaviour.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants