Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document setBindings #1928

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Document setBindings #1928

merged 1 commit into from
Mar 19, 2024

Conversation

alecmev
Copy link
Contributor

@alecmev alecmev commented Mar 19, 2024

Based on pino.d.ts:

pino/pino.d.ts

Lines 115 to 121 in dbb394f

/**
* Adds to the bindings of this logger instance.
* Note: Does not overwrite bindings. Can potentially result in duplicate keys in log lines.
*
* @param bindings: an object of key-value pairs to include in log lines as properties.
*/
setBindings(bindings: pino.Bindings): void;

<a id="logger-set-bindings"></a>
### `logger.setBindings(bindings)`

Adds to the bindings of this logger instance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Adds" or "replaces"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely "adds": #1419

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little confusing, no argument there 😛

@jsumners jsumners merged commit 36399fa into pinojs:master Mar 19, 2024
@alecmev
Copy link
Contributor Author

alecmev commented Mar 19, 2024

Thanks!

@alecmev alecmev deleted the doc-set-bindings branch March 19, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants