Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to bump version #1643

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Add script to bump version #1643

merged 1 commit into from
Feb 10, 2023

Conversation

jsumners
Copy link
Member

@jsumners jsumners commented Feb 9, 2023

Since we are saddled with maintain the version number in code, I propose this script to make releases easier. All three of the following are valid:

$ ./inc-version.sh major
$ ./inc-version.sh minor
$ ./inc-version.sh patch

By default, the following will bump for a patch release:

$ ./inc-version.sh

@jsumners jsumners requested a review from mcollina February 9, 2023 18:58
@jsumners jsumners marked this pull request as draft February 9, 2023 19:03
@jsumners jsumners marked this pull request as ready for review February 9, 2023 19:06
@mcollina
Copy link
Member

mcollina commented Feb 9, 2023

We have https://github.com/pinojs/pino/blob/master/build/sync-version.js to sync the version.

@jsumners
Copy link
Member Author

jsumners commented Feb 9, 2023

I don't know how that happens. When I bumped the version in package.json and attempted to commit it, I got test failures because that meta script didn't match. So I had to update that script as well.

With this PR:

$ ./inc-version.sh minor
$ git add .
$ git commit -m v8.10.0
$ git tag v8.10.0
$ git push && git push --tags

@mcollina
Copy link
Member

I don't know how that happens.

Manually. I launch that command. This script is good.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ba5ab33 into master Feb 10, 2023
@mcollina mcollina deleted the version-tooling branch February 10, 2023 14:05
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants