Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add syntax highlighting for typescript #1345

Merged
merged 1 commit into from
Feb 22, 2022
Merged

docs: add syntax highlighting for typescript #1345

merged 1 commit into from
Feb 22, 2022

Conversation

micalevisk
Copy link
Contributor

According to Docsify docs only few languages are supported by default by Prism (the underlying lib), and TypeScript is not. This PR adds such support on TypeScript snippets like the one at web page.

now then
before after

According to Docsify docs (https://docsify.js.org/#/language-highlight?id=language-highlighting)
only few languages are supported by default by Prism (the underlying lib), and TypeScript is not.
This commit aims to add such support on TypeScript snippets like the one at `web` page.
@github-actions
Copy link

⚠️ This pull request does not target the master branch.

@micalevisk
Copy link
Contributor Author

This pull request does not target the master branch.

well

image

@jsumners
Copy link
Member

This pull request does not target the master branch.

well

image

Ignore it. It needs to be fixed.

@micalevisk
Copy link
Contributor Author

micalevisk commented Feb 21, 2022

@jsumners changing the code below to if: ${{ github.base_ref != 'master' }} will fix that 😄

if: ${{ github.base_ref }} != "master"

preview

image


image

@github-actions
Copy link

⚠️ This pull request does not target the master branch.

@jsumners
Copy link
Member

Nope. That didn't solve it. 🤷‍♂️

@micalevisk
Copy link
Contributor Author

I tried with double quotes before and it errored-out (syntax error). Try
${{ github.base_ref != 'master' }}

@marcbachmann
Copy link
Member

tests ran properly. but looks like there's an unrelated worker error now 🤔

@marcbachmann
Copy link
Member

marcbachmann commented Feb 22, 2022

also that one: image

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants