Added documentation for MultiStreamRes, StreamEntry, DestinationStream and Level #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dbacarel
changed the title
mcollina
requested changes
Feb 16, 2022
lib/multistream.js
Outdated
| : typeof dest.level === 'number' | ||
| ? dest.level | ||
| // Default fallback level | ||
| : DEFAULT_INFO_LEVEL |
There was a problem hiding this comment.
Would you mind to restore the previous if/else block?
There was a problem hiding this comment.
of course, I restored the if/else block instead of the conditional operator - unless you meant reverting the whole change?
|
@jsumners your action did not work :( |
I see 😭 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve #1327
This PR introduces 2 top-level sections in the documentation:
InterfacesandTypesEach describes respectively the interfaces and types involved in the object returned by
pino.multistream()which is otherwise undocumented.Also:
pino.multistream().addintest/multistream.test.jspino.multistream().addintest/multistream.test.jspino.multistreamandpino.multistream.addnow throw Error if provided with an invalid stream object