Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): child is not respect customLevels #1306

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

climba03003
Copy link
Contributor

Fixes: child is not respect parent customLevels options and nested child is not inherit the customLevels options.

@climba03003
Copy link
Contributor Author

Please check if it fix your issue.
cc @MaikuMori

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from kibertoad January 21, 2022 07:22
@MaikuMori
Copy link

The fix looks good, but I didn't test it locally.

@mcollina mcollina merged commit a59f8bc into pinojs:master Jan 25, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants