Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support injecting serializers via .child() #66

Closed
mcollina opened this issue Jun 27, 2016 · 4 comments
Closed

Support injecting serializers via .child() #66

mcollina opened this issue Jun 27, 2016 · 4 comments
Labels
enhancement help wanted

Comments

@mcollina
Copy link
Member

Currently it is not possible to add serializers in child loggers.

See #57 as an example of how it could be implemented.
This was referenced Jun 27, 2016
Closed
Closed
@dgonzalez
Copy link
Contributor

Quick question, should a serializer added to the child replace the existing ones from the parent or should it be added to the existing ones? (as far as I am aware it is an array). I might be able to work on this today/weekend.

@mcollina
Copy link
Member Author

mcollina commented Jul 21, 2016 •
edited
Loading

it should be added to the existing ones, but just for that child logger, replacing the old one if it's there.

@dgonzalez
Copy link
Contributor

Perfecto. I'll try work on something today.

mcollina added a commit that referenced this issue Aug 2, 2016
@mcollina
Merge pull request #75 from dgonzalez/child-serializer
e0ed1d0 
FIxes #66: now the child loggers can override the serializers
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @dgonzalez