Merge pull request #17 from mcollina/throw-missing-bindings

Throw if creating a child logger without bindings.
pinojs · Mar 31, 2016 · 8603c35 · 8603c35
2 parents 5236950 + 7b7173d
commit 8603c35
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/pino.js b/pino.js
@@ -153,7 +153,7 @@ function setup (result, funcs, level, stream, opts, serializers, stringify) {
   result.child = child
 
   function child (bindings) {
-    if (!opts) {
+    if (!bindings) {
       throw new Error('missing bindings for child logger')
     }
 

diff --git a/test.js b/test.js
@@ -480,3 +480,17 @@ test('http request support via serializer in a child', function (t) {
     })
   })
 })
+
+test('throw if creating child without bindings', function (t) {
+  t.plan(1)
+
+  var instance = pino(
+    sink(function (chunk, enc, cb) {
+      t.ok(Date.parse(chunk.time) <= new Date(), 'time is greater than Date.now()')
+      t.end()
+    }))
+
+  t.throws(function () {
+    instance.child()
+  })
+})