New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Object.create(null) #507

Merged

mcollina merged 2 commits into pinojs:master from chrisands:fix/issue-477

Apr 27, 2024

Contributor

chrisands commented Apr 24, 2024 •

edited

Loading

Closes #477

Problem fixed here planttheidea/fast-copy#94

Add test for Object.create(null)
Update fast-copy

chrisands added 2 commits

April 24, 2024 20:55


          Add test for Object.create(null)

c8785e7


          Update fast-copy

0235bf6

chrisands force-pushed the fix/issue-477 branch from 278d60e to 0235bf6 Compare

April 24, 2024 18:56

chrisands marked this pull request as ready for review

April 24, 2024 18:57

mcollina approved these changes

View reviewed changes

Member

mcollina left a comment

lgtm

why the update of fast-copy?

Contributor Author

chrisands commented Apr 24, 2024 •

edited

Loading

@mcollina there is an issue #477 which caused pino-pretty crash when it tried to log object that was or contained nullish object with V8 optimization.

Optimized Object.create(null) that is used in fast-querystring

const Empty = function () {};
Empty.prototype = Object.create(null);

The issue was in fast-copy planttheidea/fast-copy#94. After it was resolved I updated so pino-pretty wouldn't crash on such logs.

mcollina approved these changes

View reviewed changes

Member

mcollina left a comment

lgtm

mcollina merged commit a80d977 into pinojs:master

5 checks passed

abhi-markan referenced this pull request in UK-Export-Finance/mdm-api


          chore(deps): update all (#901)

dafbf9f

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [cspell](https://streetsidesoftware.github.io/cspell/)
([source](https://togithub.com/streetsidesoftware/cspell/tree/HEAD/packages/cspell))
| [`8.8.2` ->
`8.8.3`](https://renovatebot.com/diffs/npm/cspell/8.8.2/8.8.3) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/cspell/8.8.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/cspell/8.8.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/cspell/8.8.2/8.8.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/cspell/8.8.2/8.8.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [pino-pretty](https://togithub.com/pinojs/pino-pretty) | [`11.0.0` ->
`11.1.0`](https://renovatebot.com/diffs/npm/pino-pretty/11.0.0/11.1.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino-pretty/11.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino-pretty/11.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino-pretty/11.0.0/11.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino-pretty/11.0.0/11.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [ts-jest](https://kulshekhar.github.io/ts-jest)
([source](https://togithub.com/kulshekhar/ts-jest)) | [`29.1.3` ->
`29.1.4`](https://renovatebot.com/diffs/npm/ts-jest/29.1.3/29.1.4) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/ts-jest/29.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/ts-jest/29.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/ts-jest/29.1.3/29.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/ts-jest/29.1.3/29.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>streetsidesoftware/cspell (cspell)</summary>

###
[`v8.8.3`](https://togithub.com/streetsidesoftware/cspell/blob/HEAD/packages/cspell/CHANGELOG.md#small883-2024-05-23-small)

[Compare
Source](https://togithub.com/streetsidesoftware/cspell/compare/v8.8.2...v8.8.3)

- chore: Update Integration Test Performance Data
([#&#8203;5663](https://togithub.com/streetsidesoftware/cspell/issues/5663))
([b605dd3](https://togithub.com/streetsidesoftware/cspell/commit/b605dd3)),
closes
[#&#8203;5663](https://togithub.com/streetsidesoftware/cspell/issues/5663)

</details>

<details>
<summary>pinojs/pino-pretty (pino-pretty)</summary>

###
[`v11.1.0`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.1.0)

[Compare
Source](https://togithub.com/pinojs/pino-pretty/compare/v11.0.0...v11.1.0)

#### What's Changed

- Bump tsd from 0.30.7 to 0.31.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/pinojs/pino-pretty/pull/503](https://togithub.com/pinojs/pino-pretty/pull/503)
- Fix Object.create(null) by
[@&#8203;chrisands](https://togithub.com/chrisands) in
[https://github.com/pinojs/pino-pretty/pull/507](https://togithub.com/pinojs/pino-pretty/pull/507)
- Bump sonic-boom from 3.8.1 to 4.0.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/pinojs/pino-pretty/pull/509](https://togithub.com/pinojs/pino-pretty/pull/509)
- Bump pino from 8.21.0 to 9.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/pinojs/pino-pretty/pull/510](https://togithub.com/pinojs/pino-pretty/pull/510)
- feat: automatically consume pino config when using pino@>=8.21.0 by
[@&#8203;10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in
[https://github.com/pinojs/pino-pretty/pull/508](https://togithub.com/pinojs/pino-pretty/pull/508)
- fix: pass error-like objects
([#&#8203;505](https://togithub.com/pinojs/pino-pretty/issues/505)) by
[@&#8203;aqemi](https://togithub.com/aqemi) in
[https://github.com/pinojs/pino-pretty/pull/506](https://togithub.com/pinojs/pino-pretty/pull/506)
- Add node v22 to CI by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[https://github.com/pinojs/pino-pretty/pull/511](https://togithub.com/pinojs/pino-pretty/pull/511)
- feat: Added exports color support in TTY by
[@&#8203;synapse](https://togithub.com/synapse) in
[https://github.com/pinojs/pino-pretty/pull/513](https://togithub.com/pinojs/pino-pretty/pull/513)

#### New Contributors

- [@&#8203;chrisands](https://togithub.com/chrisands) made their first
contribution in
[https://github.com/pinojs/pino-pretty/pull/507](https://togithub.com/pinojs/pino-pretty/pull/507)
- [@&#8203;aqemi](https://togithub.com/aqemi) made their first
contribution in
[https://github.com/pinojs/pino-pretty/pull/506](https://togithub.com/pinojs/pino-pretty/pull/506)
- [@&#8203;synapse](https://togithub.com/synapse) made their first
contribution in
[https://github.com/pinojs/pino-pretty/pull/513](https://togithub.com/pinojs/pino-pretty/pull/513)

**Full Changelog**:
pinojs/pino-pretty@v11.0.0...v11.1.0

</details>

<details>
<summary>kulshekhar/ts-jest (ts-jest)</summary>

###
[`v29.1.4`](https://togithub.com/kulshekhar/ts-jest/blob/HEAD/CHANGELOG.md#2914-2024-05-28)

[Compare
Source](https://togithub.com/kulshekhar/ts-jest/compare/v29.1.3...v29.1.4)

##### Bug Fixes

- fix(transformer): allow transforming of .cts/.mts extensions.
([#&#8203;3996](https://togithub.com/kulshekhar/ts-jest/issues/3996))
([b8f6eaa](https://togithub.com/kulshekhar/ts-jest/commit/b8f6eaa)),
closes
[#&#8203;3996](https://togithub.com/kulshekhar/ts-jest/issues/3996)

##### Features

- feat: make cli generate esm config based on `type: "module"`
([#&#8203;4210](https://togithub.com/kulshekhar/ts-jest/issues/4210))
([81a5f64](https://togithub.com/kulshekhar/ts-jest/commit/81a5f64)),
closes
[#&#8203;4210](https://togithub.com/kulshekhar/ts-jest/issues/4210)
[#&#8203;4012](https://togithub.com/kulshekhar/ts-jest/issues/4012)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/UK-Export-Finance/mdm-api).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Abhi Markan <32125108+abhi-markan@users.noreply.github.com>

renovate bot referenced this pull request in open-feature/playground


          fix(deps): update dependency pino-pretty to v11.2.2 (#340)

c1054e9

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino-pretty](https://togithub.com/pinojs/pino-pretty) | [`11.0.0` ->
`11.2.2`](https://renovatebot.com/diffs/npm/pino-pretty/11.0.0/11.2.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino-pretty/11.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino-pretty/11.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino-pretty/11.0.0/11.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino-pretty/11.0.0/11.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino-pretty (pino-pretty)</summary>

###
[`v11.2.2`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.2.2)

[Compare
Source](https://togithub.com/pinojs/pino-pretty/compare/v11.2.1...v11.2.2)

#### What's Changed

- Type fixes by [@&#8203;joshkel](https://togithub.com/joshkel) in
[https://github.com/pinojs/pino-pretty/pull/522](https://togithub.com/pinojs/pino-pretty/pull/522)

#### New Contributors

- [@&#8203;joshkel](https://togithub.com/joshkel) made their first
contribution in
[https://github.com/pinojs/pino-pretty/pull/522](https://togithub.com/pinojs/pino-pretty/pull/522)

**Full Changelog**:
pinojs/pino-pretty@v11.2.1...v11.2.2

###
[`v11.2.1`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.2.1):
v11

[Compare
Source](https://togithub.com/pinojs/pino-pretty/compare/v11.2.0...v11.2.1)

#### What's Changed

- Fix: add missing useOnlyCustomProps options to type definitions by
[@&#8203;pcdevil](https://togithub.com/pcdevil) in
[https://github.com/pinojs/pino-pretty/pull/514](https://togithub.com/pinojs/pino-pretty/pull/514)

#### New Contributors

- [@&#8203;pcdevil](https://togithub.com/pcdevil) made their first
contribution in
[https://github.com/pinojs/pino-pretty/pull/514](https://togithub.com/pinojs/pino-pretty/pull/514)

**Full Changelog**:
pinojs/pino-pretty@v11.2.0...v11.2.1

###
[`v11.2.0`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.2.0)

[Compare
Source](https://togithub.com/pinojs/pino-pretty/compare/v11.1.0...v11.2.0)

#### What's Changed

- fix: add injection of lacking arguments of customPrettifiers by
[@&#8203;pasha-vuiko](https://togithub.com/pasha-vuiko) in
[https://github.com/pinojs/pino-pretty/pull/501](https://togithub.com/pinojs/pino-pretty/pull/501)

#### New Contributors

- [@&#8203;pasha-vuiko](https://togithub.com/pasha-vuiko) made their
first contribution in
[https://github.com/pinojs/pino-pretty/pull/501](https://togithub.com/pinojs/pino-pretty/pull/501)

**Full Changelog**:
pinojs/pino-pretty@v11.1.0...v11.2.0

###
[`v11.1.0`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.1.0)

[Compare
Source](https://togithub.com/pinojs/pino-pretty/compare/v11.0.0...v11.1.0)

#### What's Changed

- Bump tsd from 0.30.7 to 0.31.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/pinojs/pino-pretty/pull/503](https://togithub.com/pinojs/pino-pretty/pull/503)
- Fix Object.create(null) by
[@&#8203;chrisands](https://togithub.com/chrisands) in
[https://github.com/pinojs/pino-pretty/pull/507](https://togithub.com/pinojs/pino-pretty/pull/507)
- Bump sonic-boom from 3.8.1 to 4.0.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/pinojs/pino-pretty/pull/509](https://togithub.com/pinojs/pino-pretty/pull/509)
- Bump pino from 8.21.0 to 9.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/pinojs/pino-pretty/pull/510](https://togithub.com/pinojs/pino-pretty/pull/510)
- feat: automatically consume pino config when using pino@>=8.21.0 by
[@&#8203;10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in
[https://github.com/pinojs/pino-pretty/pull/508](https://togithub.com/pinojs/pino-pretty/pull/508)
- fix: pass error-like objects
([#&#8203;505](https://togithub.com/pinojs/pino-pretty/issues/505)) by
[@&#8203;aqemi](https://togithub.com/aqemi) in
[https://github.com/pinojs/pino-pretty/pull/506](https://togithub.com/pinojs/pino-pretty/pull/506)
- Add node v22 to CI by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[https://github.com/pinojs/pino-pretty/pull/511](https://togithub.com/pinojs/pino-pretty/pull/511)
- feat: Added exports color support in TTY by
[@&#8203;synapse](https://togithub.com/synapse) in
[https://github.com/pinojs/pino-pretty/pull/513](https://togithub.com/pinojs/pino-pretty/pull/513)

#### New Contributors

- [@&#8203;chrisands](https://togithub.com/chrisands) made their first
contribution in
[https://github.com/pinojs/pino-pretty/pull/507](https://togithub.com/pinojs/pino-pretty/pull/507)
- [@&#8203;aqemi](https://togithub.com/aqemi) made their first
contribution in
[https://github.com/pinojs/pino-pretty/pull/506](https://togithub.com/pinojs/pino-pretty/pull/506)
- [@&#8203;synapse](https://togithub.com/synapse) made their first
contribution in
[https://github.com/pinojs/pino-pretty/pull/513](https://togithub.com/pinojs/pino-pretty/pull/513)

**Full Changelog**:
pinojs/pino-pretty@v11.0.0...v11.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/open-feature/playground).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet