Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow prettifier for messageKey as number #302

Closed
wants to merge 3 commits into from
Closed

feat: allow prettifier for messageKey as number #302

wants to merge 3 commits into from

Conversation

LRipi
Copy link

@LRipi LRipi commented Feb 15, 2022

Add support for messageKey as a number.
PR related to issue #181

@doums
Copy link

doums commented Feb 15, 2022

Best PR ever made 🥇

mcollina
mcollina requested changes Feb 15, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a unit test?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1848132796

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1752068244: 0.0%
Covered Lines: 350
Relevant Lines: 350
💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 15, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1848132796

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1752068244: 0.0%
Covered Lines: 350
Relevant Lines: 350
💛 - Coveralls

@mcollina
Copy link
Member

Closing for no activity.

@mcollina mcollina closed this Aug 17, 2022
1toldyou added a commit to 1toldyou/pino-pretty-number that referenced this pull request Feb 9, 2023
@1toldyou
steal pinojs/pino-pretty#302
9d77e19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina requested changes

@Mheaus Mheaus Mheaus approved these changes

@doums doums doums approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LRipi @doums @coveralls @mcollina @Mheaus