feat: gray out meta data object when using --singleLine=true

[gr2m]

fixes #160

Before

After

[coveralls]

Pull Request Test Coverage Report for Build 619166069

• 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 100.0%

---

Totals
Change from base Build 614985914:	0.0%
Covered Lines:	265
Relevant Lines:	265

---

💛 - Coveralls

[gr2m]

I am confused, the tests should not have passed with the changes from 6641ce0, I only pushed the tests changes to show that they are failing, before pushing the fix

[gr2m]

Is it possible that on CI the colors are disabled, so testing for colors is impossible?

[gr2m]

When running this locally I get

[gr2m]

I'm not sure if this only affects my code, but it looks like tests for colors in stdout won't work in CI because colors are disabled by default. If the code changes from this PR were removed in future, the tests would still pass in CI (but fail locally)

[mcollina]

You should use https://github.com/pinojs/pino-pretty/blob/master/lib/colors.js and not chalk directly. You'll be able to test with that.

[gr2m]

I'm sorry but I don't get how to use the colorizer API from colors.js to color the meta object output as gray (debug). Can you give me a pointer plaese

[mcollina]

The new chalk.Instance({ level }) API in

pino-pretty/lib/colors.js

Line 18 in 657b7ba

const ctx = new chalk.Instance({ level: 3 })

will print out colors even if it's disabled in the TTY.

You will need to use colorizer with the level argument of 'trace' (which is grey). The tricky part is that you'd need to percolate down the current colorizer from the caller function

[gr2m]

Sorry I've spent another 15minutes on this I just don't know what to do with the colorizer argument. colorizer has a single method .message() which does not accept a level parameter. And calling colorizer as a function only returns the name of the level, not a chalk-compatible instance, e.g. colorizer('trace') // TRACE

Do you want to finish this up yourself? I'll learn from your changes for the next time

[jsumners]

Sorry I've spent another 15minutes on this I just don't know what to do with the colorizer argument. colorizer has a single method .message() which does not accept a level parameter. And calling colorizer as a function only returns the name of the level, not a chalk-compatible instance, e.g. colorizer('trace') // TRACE

Do you want to finish this up yourself? I'll learn from your changes for the next time

https://runkit.com/embed/op9ez5z3pgxm

lib/colors returns a factory function that asks "do you want colors or not?". In either case, it returns a new function that will return a colorized level label based upon the level given, e.g. colorize('trace') or colorize('info'). This function also includes a message method that will colorize a message according to our standardized message color: colorizer.message('a message').

What you want to do is add a new method that will colorize according to a different color, e.g. colorizer.greyMessage = (msg) => colorizeLevel('trace', msg).

[gr2m]

What you want to do is add a new method that will colorize according to a different color, e.g. colorizer.greyMessage = (msg) => colorizeLevel('trace', msg).

I would add that code to lib/colors.js as part of the factory function?

[jsumners]

I would add that code to lib/colors.js as part of the factory function?

I would expect to see it defined for each colorizer type in the same general location as the definition of colorizer.message.

[gr2m]

see my commit at 2d7ca36

That makes the tests fail locally now. How do I test for the color output?

[jsumners]

That makes the tests fail locally now. How do I test for the color output?

pino-pretty/test/lib/colors.test.js

Line 42 in 657b7ba

t.is(colorized, '\u001B[90mTRACE\u001B[39m')

[gr2m]

okay so I can write a unit test for the colorizer.greyMessage method, but I cannot test the color of the log output in basic.test.js?

[jsumners]

okay so I can write a unit test for the colorizer.greyMessage method, but I cannot test the color of the log output in basic.test.js?

Is there a need to? If the colorizer is working as tested, then the final result is going to be correct, yes?

[gr2m]

okay, just wanted to make sure. I think it would be better to have some integration tests, because in theory the usage of colorizer.greyMessage in prettifyObject() could be removed, but the tests would continue to pass.

I think I'm all set now, I'll finish this up. Thank you so much for bearing with me

[gr2m]

I think this is ready

[mcollina]

lgtm

[jsumners]

LGTM

Should a note about the different coloring be added to the documentation for the single line option?

[mcollina]

I don't think we should add any note.