-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
Even if I clone main repo and run tests the same two tests are failing.
|
The problem is with |
Turns out pinojs/pino-pretty#117 broke the tests here. cc @jsumners I think pinojs/pino-pretty#117 has a bug, I'll open a PR there. @robertsLando downgrading to 3.6.1 is definitely not the solution. |
Was to show you where the bug is, I will wait for the next pino-pretty release 👍 |
pino-pretty v4.0.2 was just released with the fix. |
@mcollina Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: James Sumners <james@sumners.email>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let me know when a new release with this feat will be available, thanks :) |
fixes #37