Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After update 1.1.7 routes are not found anymore #61

Closed
ronnievisser opened this issue Nov 25, 2014 · 7 comments
Closed

After update 1.1.7 routes are not found anymore #61

ronnievisser opened this issue Nov 25, 2014 · 7 comments

Comments

@ronnievisser
Copy link

Hi,

I just upgraded to version 1.1.7 and now all the routes of all my packages could not be found anymore. laravel is throwing the following exception: Symfony \ Component \ HttpKernel \ Exception \ NotFoundHttpException. Going back to version 1.1.6 solves my problem for now!

@gravitano
Copy link
Member

Add start.php to files array in the module.json file. Please see the example in this file https://github.com/pingpong-labs/modules/blob/master/src/Pingpong/Modules/Commands/stubs/json.stub

@nWidart
Copy link
Member

nWidart commented Nov 25, 2014

I've got the same issue here.
I've added the start file in the 'files' array, but still got at HttpException.

@nWidart
Copy link
Member

nWidart commented Nov 25, 2014

I wouldn't load the routes file by default.
I'm using Laravel 5 to load my routes. See https://github.com/AsgardCms/User/blob/master/Providers/RouteServiceProvider.php for example.

@gravitano
Copy link
Member

@nWidart : have you registering its service provider?

@nWidart
Copy link
Member

nWidart commented Nov 25, 2014

Yes. See : https://github.com/AsgardCms/User/blob/master/module.json#L7
Still getting that weird HttpException though :/

@nWidart
Copy link
Member

nWidart commented Nov 25, 2014

I've tried using the classic way to include the routes files, that is from a start.php file, adding require __DIR__ . '/Http/routes.php'; , also adding that to the files array in module.json.
But got that same HttpException.

@nWidart nWidart mentioned this issue Nov 25, 2014
@ronnievisser
Copy link
Author

Upgrading to 1.1.9 Should help. Existing modules Should be recreated is my expierence


Sent from Mailbox

On Tue, Nov 25, 2014 at 5:27 PM, Nicolas Widart notifications@github.com
wrote:

I've tried using the classic way to include the routes files, that is from a start.php file, adding require __DIR__ . '/Http/routes.php'; , also adding that to the files array in module.json.

But got that same HttpException.

Reply to this email directly or view it on GitHub:
#61 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants