Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime] Use logrus and remove log.Fatal in generated table definition #9

Merged
merged 3 commits into from
Sep 16, 2018
Merged

[runtime] Use logrus and remove log.Fatal in generated table definition #9

merged 3 commits into from
Sep 16, 2018

Conversation

pingginp
Copy link
Owner

@pingginp
[runtime] Use logrus instead of stdlog
e6dfa5d 
- similar to #8
@pingginp
[gen] Replace log.Fatalf w/ errors.Errorf
d457ca9 
- in generated table definitions, was using log.Fatalf, that function
returns error, better just return errors.Errorf
@pingginp pingginp added comp/runtime cqlc runtime, the query builder comp/generator generate table defintion from live db schema labels Sep 16, 2018
@pingginp pingginp added this to the 0.11.0 milestone Sep 16, 2018
@pingginp pingginp merged commit d426ffc into master Sep 16, 2018
@pingginp pingginp deleted the logrus branch September 16, 2018 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comp/generator generate table defintion from live db schema comp/runtime cqlc runtime, the query builder
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
1 participant
@pingginp