Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix index scan bug #995

Merged
merged 4 commits into from
Aug 8, 2019
Merged

fix index scan bug #995

merged 4 commits into from
Aug 8, 2019

Conversation

zhexuany
Copy link
Contributor

@zhexuany zhexuany commented Aug 7, 2019

What problem does this PR solve?

When we do index scan, we should not add required index data type.

What is changed and how it works?

Remove related code in double read case.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

@zhexuany zhexuany requested a review from birdstorm August 7, 2019 06:29
@zhexuany
Copy link
Contributor Author

zhexuany commented Aug 7, 2019

@birdstorm @marsishandsome PTAL

@marsishandsome
Copy link
Collaborator

cherry pick to release-2.1?

Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhexuany zhexuany added CHANGELOG PR which needs to record in CHANGELOG.md needs-cherry-pick-2.1 labels Aug 7, 2019
@zhexuany
Copy link
Contributor Author

zhexuany commented Aug 7, 2019

/run-all-tests

1 similar comment
@zhexuany
Copy link
Contributor Author

zhexuany commented Aug 7, 2019

/run-all-tests

@zhexuany zhexuany force-pushed the fix_index_scan_bug branch from 0116304 to 2428858 Compare August 8, 2019 05:09
@zhexuany
Copy link
Contributor Author

zhexuany commented Aug 8, 2019

/run-all-tests

@zhexuany zhexuany merged commit 911e890 into pingcap:master Aug 8, 2019
@zhexuany zhexuany deleted the fix_index_scan_bug branch August 8, 2019 08:21
marsishandsome pushed a commit to marsishandsome/tispark that referenced this pull request Aug 15, 2019
(cherry picked from commit 911e890)
marsishandsome added a commit that referenced this pull request Aug 15, 2019
(cherry picked from commit 911e890)
marsishandsome added a commit that referenced this pull request Aug 29, 2019
* 2.2.0 -> 2.3.0 (#947)

* Add tests for primary key (#948)

* add changelog (#955)

* add multi-column tests (#954)

* fix range partition throw UnsupportedSyntaxException error (#960)

* fix view parsing problem (#953)

* make tispark can read from a hash partition table (#966)

* increase ci worker number (#965)

* update readme for tispark-2.1.2 release (#968)

* update document for pyspark (#975)

* fix one jar bug (#972)

* adding common port number used by spark cluster (#973)

* fix cost model in table scan (#977)

* create an UninitializedType for TypeDecimal (#979)

* update sparkr doc (#976)

* use spark-2.4.3 to run ut (#978)

* use spark-2.4.3 to run ut

* fix ci

* a better design for get auto table id (#980)

* fix bug: ci SpecialTiDBTypeTestSuite failed with tidb-3.0.1 (#984)

* improve TiConfiguration getPdAddrsString function (#963)

* bump grpc to 1.17 (#982)

* Add multiple-column PK tests (#970)

* add retry for batchGet (#986)

* use tispark self-made m2 cahce file (#990)

* add spark sql document for batch write (#991)

* add auto mode for test.data.load (#994)

* fix typo (#996)

* fix index scan bug (#995)

* refine doc (#1003)

* add tidb-3.0 compatibility document (#998)

* add tidb-3.0 compatibility document

* address code review

* address code review

* add log4j config document (#1008)

* refactor batch write region pre-split (#999)

* add ci simple mode (#1012)

* clean up redundant code (#997)

* prohibit agg or groupby pushdown on double read (#1004)

* remove split region code (#1015)

* add supported scala version (#1013)

* Fix scala compiler version (#1010)

* fix reflection bug for hdp release (#1017) (#1018)

(cherry picked from commit 118b12e)

* check by grammarly (#1022)

* add benchmark result for batch write (#1025)

* release tispark 2.1.3 (#1026) (#1035)

(cherry picked from commit 107eb2b)

* support setting random seed in daily regression test (#1032)

* Remove create in tisession (#1021)

* set tikv region size from 96M to 1M (#1031)

* adding unique indices test for batch write (#1014)

* use one unique seed (#1043)

* remove unused code (#1030)

* adding batch write pk insertion test (#1044)

* fix table not found bug in TiSession because of synchronization (#1041)

* fix test failure (#1051)

* fix reflection bug: pass in different arguments for different version of same function (#1037) (#1052)

(cherry picked from commit a5462c2)

* Adding pk and unique index test for batch write (#1049)

* fix distinct without alias bug: disable pushdown aggregate with alias (#1054)

* improve the doc (#1053)

* Refactor RegionStoreClient logic (#989)

* using stream rather removeIf (#1057)

* Remove redundant pre-write/commit logic in LockResolverTest (#1062)

* adding recreate flag when create tisession (#1064)

* fix issue 1047 (#1066)

* cleanup code in TiBatchWrite (#1067)

* release tispark-2.1.4 (#1068) (#1069)

(cherry picked from commit fd8068a)

* update document for tispark-2.1.4 release (#1070)
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHANGELOG PR which needs to record in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants