Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forbid write to table with generated column #907

Merged

Conversation

marsishandsome
Copy link
Collaborator

close #906

@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@birdstorm
Copy link
Contributor

Consider also update the document about what scenario do we support and what we do not?

@marsishandsome
Copy link
Collaborator Author

Consider also update the document about what scenario do we support and what we do not?

yes, i will update the document before release. (we also do not support partition table which will also be included in document.)

Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhexuany zhexuany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhexuany zhexuany merged commit 787ee74 into pingcap:master Jul 5, 2019
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forbid write to table with generated column
3 participants