-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix outputoffset when build dag req #615
Fix outputoffset when build dag req #615
Conversation
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
========================================
Coverage ? 53.9%
Complexity ? 983
========================================
Files ? 136
Lines ? 6402
Branches ? 759
========================================
Hits ? 3451
Misses ? 2626
Partials ? 325
Continue to review full report at Codecov.
|
it will be better if bug fixing & refactor are in separated PR |
/run-all-tests tikv=release-2.1 tidb=release-2.1 pd=release-2.1 |
LGTM |
8a07409
to
5e1d65b
Compare
@marsishandsome PTAL. In this PR, only fix will be merged into master. |
28251af
to
1f8ca81
Compare
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM computeIfAbsent would be better, but we can leave it to next PR.
LGTM |
Say we have a query
select id, id, it, it from t
.In the past, we construct a DAG req as follows:
It works in old TiKV, but not in the latest tikv.
The expected table scan is as follow:
This PR fixes this.