Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ti version usable without selecting database #545

Merged
merged 1 commit into from
Jan 5, 2019
Merged

Make ti version usable without selecting database #545

merged 1 commit into from
Jan 5, 2019

Conversation

birdstorm
Copy link
Contributor

Fix #543

@birdstorm
Copy link
Contributor Author

/run-all-tests

ilovesoup
ilovesoup reviewed Jan 4, 2019
View reviewed changes
Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this change? Does it involve reflection?

@birdstorm
Copy link
Contributor Author

@ilovesoup We do, because TiResolutionRule is implied when extension is set. changing it from lazy will make TiContext be initialized in injection state, before we use use $database statement.

@zhexuany zhexuany merged commit 0e214c4 into master Jan 5, 2019
@zhexuany zhexuany deleted the fix_ti_version branch January 5, 2019 13:46
birdstorm added a commit that referenced this pull request Jan 8, 2019
@birdstorm
Make ti version usable without selecting database (#545)
0ec1898
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@birdstorm @zhexuany
Make ti version usable without selecting database (pingcap#545)
0383379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilovesoup ilovesoup ilovesoup left review comments

@zhexuany zhexuany zhexuany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@birdstorm @ilovesoup @zhexuany