Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PD connection issue's error log #388

Merged
merged 2 commits into from
Jul 16, 2018
Merged

Improve PD connection issue's error log #388

merged 2 commits into from
Jul 16, 2018

Conversation

birdstorm
Copy link
Contributor

fix #387

@codecov-io
Copy link

codecov-io commented Jul 11, 2018 •
edited
Loading

Codecov Report

Merging #388 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage    55.2%   55.18%   -0.02%     
==========================================
  Files         127      127              
  Lines        5809     5811       +2     
  Branches      863      864       +1     
==========================================
  Hits         3207     3207              
- Misses       2311     2312       +1     
- Partials      291      292       +1
Impacted Files Coverage Δ
...lient/src/main/java/com/pingcap/tikv/PDClient.java 74.49% <0%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dc8769...9ea49dd. Read the comment docs.

@birdstorm
Copy link
Contributor Author

@ilovesoup PTAL

ilovesoup
ilovesoup approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error message is misleading. Should be PD client is not initialized

@ilovesoup ilovesoup merged commit 59565b9 into master Jul 16, 2018
@ilovesoup ilovesoup deleted the improve_pdClient_log branch July 16, 2018 12:40
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@birdstorm @ilovesoup
Improve PD connection issue's error log (pingcap#388)
3669a64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilovesoup ilovesoup ilovesoup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve PD connection issue's error log
3 participants
@birdstorm @codecov-io @ilovesoup