Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: license checker #2263

Merged
merged 21 commits into from
Mar 19, 2022
Merged

ADD: license checker #2263

merged 21 commits into from
Mar 19, 2022

Conversation

xuanyu66
Copy link
Collaborator

@xuanyu66 xuanyu66 commented Mar 11, 2022

What problem does this PR solve?

  • Add license checker in order to check license automatically
  • Fix the wrong license header

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 11, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shiyuhang0
  • sunxiaoguang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@xuanyu66
Copy link
Collaborator Author

@tisonkun Hello, sorry to disrupt you, would you please help me find out why this license checker always fail

@tisonkun
Copy link

@xuanyu66 because files you checked miss the license header. You can check from the error logs to find files doesn't meet the requirement.

https://github.com/pingcap/tispark/runs/5509671375?check_suite_focus=true

@tisonkun
Copy link

The license header is incorrect.

@tisonkun
Copy link

Check pingcap/tidb#27198 for the reason. The license header is incorrect and copyed everywhere. You can do a global find and replace to fix it.

@xuanyu66
Copy link
Collaborator Author

@tisonkun thank you. It doesn't occur to me that license header is in correct

@xuanyu66
Copy link
Collaborator Author

/cherrypick release-2.5

@ti-chi-bot
Copy link
Member

@xuanyu66: once the present PR merges, I will cherry-pick it on top of release-2.5 in the new PR and assign it to you.

In response to this:

/cherrypick release-2.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xuanyu66
Copy link
Collaborator Author

/cherrypick release-2.4

@ti-chi-bot
Copy link
Member

@xuanyu66: once the present PR merges, I will cherry-pick it on top of release-2.4 in the new PR and assign it to you.

In response to this:

/cherrypick release-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xuanyu66
Copy link
Collaborator Author

/run-all-tests

@xuanyu66
Copy link
Collaborator Author

@zhangyangyu @shiyuhang0 PLTA

@ti-chi-bot
Copy link
Member

@zhangyangyu: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xuanyu66
Copy link
Collaborator Author

/run-all-tests

@xuanyu66
Copy link
Collaborator Author

/run-all-tests

@sunxiaoguang
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e8a0526

@ti-chi-bot ti-chi-bot merged commit 3f7382e into pingcap:master Mar 19, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Mar 19, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@xuanyu66: new pull request created: #2271.

In response to this:

/cherrypick release-2.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Mar 19, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@xuanyu66: new pull request created: #2272.

In response to this:

/cherrypick release-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants