-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix resolve lock bug with tiflash #1483
Merged
marsishandsome
merged 1 commit into
pingcap:master
from
marsishandsome:feature/batch-write-tiflash
Jun 19, 2020
Merged
fix resolve lock bug with tiflash #1483
marsishandsome
merged 1 commit into
pingcap:master
from
marsishandsome:feature/batch-write-tiflash
Jun 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsishandsome
force-pushed
the
feature/batch-write-tiflash
branch
from
June 18, 2020 09:19
017cbfd
to
31c4ac7
Compare
/run-all-tests tikv=v4.0.1 tidb=v4.0.1 pd=v4.0.1 |
marsishandsome
force-pushed
the
feature/batch-write-tiflash
branch
from
June 18, 2020 09:34
31c4ac7
to
7d48918
Compare
/run-all-tests tikv=v4.0.1 tidb=v4.0.1 pd=v4.0.1 |
/run-all-tests tikv=v4.0.0 tidb=v4.0.0 pd=v4.0.0 |
birdstorm
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
birdstorm
reviewed
Jun 18, 2020
marsishandsome
force-pushed
the
feature/batch-write-tiflash
branch
from
June 19, 2020 04:17
f1d51a8
to
352cf94
Compare
marsishandsome
force-pushed
the
feature/batch-write-tiflash
branch
from
June 19, 2020 04:18
352cf94
to
0e4145c
Compare
/run-all-tests tikv=v4.0.1 tidb=v4.0.1 pd=v4.0.1 |
1 similar comment
/run-all-tests tikv=v4.0.1 tidb=v4.0.1 pd=v4.0.1 |
wfxxh
pushed a commit
to wanfangdata/tispark
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
resolve lock grpc request should be sent to TiKV, but currently it may be sent to TiFlash
What is changed and how it works?
send resolve lock grpc request to TiKV
Check List
Tests