Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resolve lock bug with tiflash #1483

Merged

Conversation

marsishandsome
Copy link
Collaborator

@marsishandsome marsishandsome commented Jun 18, 2020

What problem does this PR solve?

resolve lock grpc request should be sent to TiKV, but currently it may be sent to TiFlash

What is changed and how it works?

send resolve lock grpc request to TiKV

Check List

Tests

  • Unit test

@marsishandsome marsishandsome force-pushed the feature/batch-write-tiflash branch from 017cbfd to 31c4ac7 Compare June 18, 2020 09:19
@marsishandsome
Copy link
Collaborator Author

/run-all-tests tikv=v4.0.1 tidb=v4.0.1 pd=v4.0.1

@marsishandsome marsishandsome force-pushed the feature/batch-write-tiflash branch from 31c4ac7 to 7d48918 Compare June 18, 2020 09:34
@marsishandsome
Copy link
Collaborator Author

/run-all-tests tikv=v4.0.1 tidb=v4.0.1 pd=v4.0.1

@marsishandsome
Copy link
Collaborator Author

/run-all-tests tikv=v4.0.0 tidb=v4.0.0 pd=v4.0.0

Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome force-pushed the feature/batch-write-tiflash branch from f1d51a8 to 352cf94 Compare June 19, 2020 04:17
@marsishandsome marsishandsome force-pushed the feature/batch-write-tiflash branch from 352cf94 to 0e4145c Compare June 19, 2020 04:18
@marsishandsome
Copy link
Collaborator Author

/run-all-tests tikv=v4.0.1 tidb=v4.0.1 pd=v4.0.1

1 similar comment
@marsishandsome
Copy link
Collaborator Author

/run-all-tests tikv=v4.0.1 tidb=v4.0.1 pd=v4.0.1

@marsishandsome marsishandsome merged commit a73c662 into pingcap:master Jun 19, 2020
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants