Fix task retry if tikv is down #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
marsishandsome
added
needs-cherry-pick-2.2
needs-cherry-pick-master
birdstorm
reviewed
Nov 13, 2019
| @@ -248,6 +248,6 @@ public boolean handleRequestError(BackOffer backOffer, Exception e) { | |||
| BackOffFunction.BackOffFuncType.BoTiKVRPC, | |||
| new GrpcException( | |||
| "send tikv request error: " + e.getMessage() + ", try next peer later", e)); | |||
| return true; | |||
| return false; | |||
There was a problem hiding this comment.
mind if we add a comment for this change?
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-2.1 #1207 +/- ##
==============================================
Coverage ? 53.29%
Complexity ? 1122
==============================================
Files ? 153
Lines ? 7027
Branches ? 821
==============================================
Hits ? 3745
Misses ? 2908
Partials ? 374
Continue to review full report at Codecov.
|
marsishandsome
added a commit
to marsishandsome/tispark
that referenced
this pull request
Nov 14, 2019
marsishandsome
added a commit
to marsishandsome/tispark
that referenced
this pull request
Nov 14, 2019
marsishandsome
added a commit
to marsishandsome/tispark
that referenced
this pull request
Nov 14, 2019
marsishandsome
added a commit
to marsishandsome/tispark
that referenced
this pull request
Nov 14, 2019
marsishandsome
added a commit
that referenced
this pull request
Nov 14, 2019
marsishandsome
added a commit
that referenced
this pull request
Nov 14, 2019
wfxxh
pushed a commit
to wanfangdata/tispark
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #1208
Retry fails if TiKV is down during spark task running
What is changed and how it works?
if TiKV is down during spark task running, tispark will refetch leader from PD.
Check List
Tests
Related changes