-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manager, config: watch and apply the latest log configuration online #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhebox
reviewed
Sep 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
xhebox
reviewed
Sep 23, 2022
xhebox
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
xhebox
pushed a commit
to xhebox/TiProxy
that referenced
this pull request
Mar 7, 2023
xhebox
pushed a commit
to xhebox/TiProxy
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #94
Problem Summary:
Log configurations need to take effect dynamically.
What is changed and how it works:
LoggerManager
.LoggerManager
byServer
and remove the logs inmain()
.TODO:
The
LoggerManager
relies on theConfigManager
to get the log path, butConfigManager
relies onLoggerManager
to get the logger. Currently,LoggerManager
logs to the path specified in the static config first and then switches to the path specified in the dynamic config. There are some ways to solve it:ConfigManager
before the logger is initializedCheck List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.