Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy/net: human readable capability flag #89

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Sep 21, 2022

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Issue Number: close None

Problem Summary: The motivation is that I want to print capability difference between server and proxy in a human readable format. I'll modify all capability flags in the package to this type later. And maybe cherry pick the change to tidb/parser.

What is changed and how it works: A new capability flag type with fmt.Sringer and TextMarshaler.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has weirctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@djshow832 djshow832 merged commit f3c5305 into pingcap:main Sep 21, 2022
@xhebox xhebox deleted the minor_1 branch November 2, 2022 08:51
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 7, 2023
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants