-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: new tls configuration for operator #80
Conversation
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
copy(end, key) | ||
for i := len(end) - 1; i >= 0; i-- { | ||
if end[i] < 0xff { | ||
end[i] = end[i] + 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean?
If you get the prefix of a string, why not just use string functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy from etcd server source, in short the next nextLargestKey
. It is not related to string or whatever.
Co-authored-by: djshow832 <zhangming@pingcap.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe xw897002528@gmail.com
What problem does this PR solve?
Issue Number: ref #69, ref #64
Problem Summary: TLS refine
What is changed and how it works:
cluster-tls
for cluster client secretserver-tls
for sql port, HTTP portsql-tls
to connect TiDB sql portpeer-tls
for peer communicationhttps
if setserver-tls
, will check TiDB health by https ifcluster-tls
setconfig manager
to used etcd server instead of etcd client. Because if user pass a CA toserver-tls
, connect to2379
may failInsecureSkipVerify
forCreateTLSConfigForTest
, use DNSserverAddr
instead ofbackendIO.RemoteAddr().String()
if possibleThe tidb encoder will append like so:
Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.