Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix multi module test #78

Merged
merged 4 commits into from
Sep 9, 2022
Merged

*: fix multi module test #78

merged 4 commits into from
Sep 9, 2022

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Sep 9, 2022

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Issue Number: ref #76

Problem Summary: go commands is module based. Need to manually run for each module.

What is changed and how it works:

  1. run tests for /lib
  2. merge coverage profiles

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Ensured tests under /lib are passed.
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has weirctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xhebox
*: fix multi module test
4b2c68d 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 September 9, 2022 02:57
djshow832
djshow832 reviewed Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add license for proxy_test.go and namespace_test.go.

@xhebox
*: add license
fcb7c9f 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
Copy link
Collaborator Author

xhebox commented Sep 9, 2022

Add license for proxy_test.go and namespace_test.go.

Done

@xhebox
*: try fix windows build
1904446 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
*: trigger again
b42c412 
Signed-off-by: xhe <xw897002528@gmail.com>
@djshow832 djshow832 merged commit b1853c4 into pingcap:main Sep 9, 2022
@xhebox xhebox deleted the fix_1 branch September 9, 2022 04:52
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 7, 2023
@xhebox
*: fix multi module test (pingcap#78)
f3f7471
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
@xhebox
*: fix multi module test (pingcap#78)
2983956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xhebox @djshow832