backend, router: fix errors when closing and redirecting concurrently #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #71
Problem Summary:
These things may happen concurrently:
There are 2 problems:
BackendConnMgr.Redirect()
reports a panic because it assumes that it's not closed.Router.OnConnClosed()
cannot find the connection by the backend address, because the address passed in byBackendConnMgr
is the old one, not the new one (just sent byBackendConnMgr.Redirect()
).What is changed and how it works:
GetRedirectingAddr()
.BackendConnMgr
notify theRouter
asynchronously to:OnRedirectXXX
is called withinBackendConnMgr.processLock
. If it also waits forRouter.lock
, it's risky. Someone may write deadlock in the future.BackendConnMgr.signal
even if redirection fails to avoid deadloop redirection.BackendConnMgr
more thread-safer, including makingeventReceiver
atomical and addingwg
.Check List
Tests
Shut one of the TiDB immediately without graceful shutdown. The Router will send redirection commands because it finds it's unhealthy, but the connection also closes because the backend fails.
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.