Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: add docker support #70

Merged
merged 1 commit into from
Sep 1, 2022
Merged

docker: add docker support #70

merged 1 commit into from
Sep 1, 2022

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Sep 1, 2022

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Issue Number: ref #69

Problem Summary: Need a docker image.

What is changed and how it works: Add make docker for building an image.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
make docker
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has weirctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xhebox
docker: add docker support
8070705 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 September 1, 2022 03:45
@xhebox xhebox mentioned this pull request Sep 1, 2022
Closed
9 tasks
@xhebox xhebox merged commit 8d47abe into pingcap:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xhebox @djshow832