Make /api/debug/health return error when no backends are available #692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #689
Problem Summary:
When TiProxy starts, it may take some time to connect to PD and update the backend status. During this phase, no connections should be routed to this instance. So the HTTP API
/api/debug/health
should report an error when there's no available backends.What is changed and how it works:
NamespaceManager
and test/api/debug/health
with a mocked one.NamespaceManager.Ready()
returns true only when all the routers have at least one healthy backend./api/debug/health
returns OK only whenNamespaceManager.Ready()
and the server is not closing.Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.