Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager, replay: show the history of traffic jobs #686

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #685

Problem Summary:
Users may want to check the history of traffic jobs.

What is changed and how it works:

  • Add more fields to the jobs.
  • Marshal the jobs and return the string.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox September 25, 2024 07:30
@ti-chi-bot ti-chi-bot bot added the size/XL label Sep 25, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.62500% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@41f35d7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/sqlreplay/manager/job.go 88.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage        ?   70.18%           
=======================================
  Files           ?      102           
  Lines           ?     9888           
  Branches        ?        0           
=======================================
  Hits            ?     6940           
  Misses          ?     2456           
  Partials        ?      492           
Flag Coverage Δ
unit 70.18% <90.62%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djshow832
Copy link
Collaborator Author

/retest

Copy link

ti-chi-bot bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Sep 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-25 07:55:12.976306216 +0000 UTC m=+1638982.716730147: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 57a854f into pingcap:main Sep 25, 2024
5 checks passed
@djshow832 djshow832 deleted the status branch September 25, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the history of traffic jobs
3 participants