Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiproxyctl: change --curls to --host and --port #664

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #656

Problem Summary:
tiproxyctl --curls=127.0.0.1:3080
tidb-ctl --host=127.0.0.1 --port 10080
They are inconsistent.

What is changed and how it works:
Change tiproxyctl arguments from --curls to --host and --port

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Try bin/tiproxyctl --help and bin/tiproxyctl --host localhost --port 3080 config get

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- Change tiproxyctl arguments from --curls to --host and --port

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox September 11, 2024 06:47
@ti-chi-bot ti-chi-bot bot added the size/M label Sep 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@ca75a82). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #664   +/-   ##
=======================================
  Coverage        ?   69.35%           
=======================================
  Files           ?       95           
  Lines           ?     9174           
  Branches        ?        0           
=======================================
  Hits            ?     6363           
  Misses          ?     2341           
  Partials        ?      470           
Flag Coverage Δ
unit 69.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

ti-chi-bot bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 11, 2024
Copy link

ti-chi-bot bot commented Sep 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-11 07:43:33.953665312 +0000 UTC m=+428683.694089252: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 11, 2024
@ti-chi-bot ti-chi-bot bot merged commit aa61869 into pingcap:main Sep 11, 2024
5 checks passed
@djshow832 djshow832 deleted the host branch September 11, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the parameters of tiproxyctl consistent with tidb-ctl
3 participants