-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main: make sure the Welcome TiProxy info is always printed. #507
Conversation
Welcome @yorkhellen! It looks like this is your first PR to pingcap/tiproxy 🎉 |
Hi @yorkhellen. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage ? 64.80%
=======================================
Files ? 65
Lines ? 6037
Branches ? 0
=======================================
Hits ? 3912
Misses ? 1821
Partials ? 304
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What problem does this PR solve?
Issue Number: close #506
Problem Summary:
What is changed and how it works:
update the log level to "info" before print TiProxy info to make sure the info log is always printed.
Check List
Tests
step 1 set the log level to "error" in config file, such as :
set 2 start the TiProxy and check the TiProxy info is printed.
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.