Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router: speed up health check by checking in parallel #498

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #216

Problem Summary:
In a large cluster, checking health serially is impractical.

What is changed and how it works:

  • Define a wrapper for wait group and goroutine pool
  • Check the health by the goroutine pool

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- Speed up health check by checking in parallel

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox April 7, 2024 12:28
@ti-chi-bot ti-chi-bot bot added the size/L label Apr 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 94.00000% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@d40bfdb). Click here to learn what that means.

Files Patch % Lines
pkg/manager/router/backend_observer.go 85.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage        ?   64.83%           
=======================================
  Files           ?       61           
  Lines           ?     5846           
  Branches        ?        0           
=======================================
  Hits            ?     3790           
  Misses          ?     1762           
  Partials        ?      294           
Flag Coverage Δ
unit 64.83% <94.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

ti-chi-bot bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 8, 2024
Copy link

ti-chi-bot bot commented Apr 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-08 04:47:25.095654868 +0000 UTC m=+851306.623195415: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Apr 8, 2024
@ti-chi-bot ti-chi-bot bot merged commit 961377d into pingcap:main Apr 8, 2024
4 of 5 checks passed
@djshow832 djshow832 deleted the health_check branch April 8, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up health check
3 participants