Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: add cmd arg advertise-addr #497

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #494

Problem Summary:
For TiDB-Operator, it's not easy to pass advertise-addr into the config file.

What is changed and how it works:

  • Add a cmd argument advertise-addr

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

In the TiProxy container logs:

starting: tiproxy --config=/etc/proxy/proxy.toml --advertise-addr=basic-tiproxy-0.basic-tiproxy-peer.tidb-cluster.svc

Query the TiProxy config:

curl http://127.1:3080/api/admin/config/ | grep advertise
advertise-addr = 'basic-tiproxy-0.basic-tiproxy-peer.tidb-cluster.svc'

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- Add a command line argument `advertise-addr`

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox April 5, 2024 03:06
@ti-chi-bot ti-chi-bot bot added the size/XS label Apr 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@b543b47). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #497   +/-   ##
=======================================
  Coverage        ?   64.18%           
=======================================
  Files           ?       61           
  Lines           ?     5814           
  Branches        ?        0           
=======================================
  Hits            ?     3732           
  Misses          ?     1792           
  Partials        ?      290           
Flag Coverage Δ
unit 64.18% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

ti-chi-bot bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 5, 2024
Copy link

ti-chi-bot bot commented Apr 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-05 13:59:00.824396029 +0000 UTC m=+625202.351936567: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Apr 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit 1a2c0c8 into pingcap:main Apr 5, 2024
5 checks passed
@djshow832 djshow832 deleted the advertise branch April 6, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiDB table information_schema.cluster_config cannot show TiProxy configs
3 participants