Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: recover goroutines when they panic #488

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #487

Problem Summary:
The goroutine BackendConnMgr.processSignals() doesn't handle panic, so TiProxy will be down when it panics.

What is changed and how it works:

  • Add recovery for most of goroutines.
  • Remove WithRecovery() because WaitGroup already has RunWithRecover().
  • Add defer processLock.Unlock() in BackendConnMgr.processSignals() so that the locks can be released before cleanup.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- Fix the bug that some goroutines are not recovered after they panic.

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox March 19, 2024 12:37
@ti-chi-bot ti-chi-bot bot added the size/L label Mar 19, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@9f2db8e). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #488   +/-   ##
=======================================
  Coverage        ?   64.36%           
=======================================
  Files           ?       61           
  Lines           ?     5809           
  Branches        ?        0           
=======================================
  Hits            ?     3739           
  Misses          ?     1782           
  Partials        ?      288           
Flag Coverage Δ
unit 64.36% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

ti-chi-bot bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 20, 2024
Copy link

ti-chi-bot bot commented Mar 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-20 02:01:38.52287036 +0000 UTC m=+1428525.545116748: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Mar 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit 233f456 into pingcap:main Mar 20, 2024
5 checks passed
@djshow832 djshow832 deleted the fix_recover branch March 20, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiProxy is down when there's a nil pointer panic
3 participants