Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: support get json format for config by setting Accept header #484

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

djshow832
Copy link
Collaborator

@djshow832 djshow832 commented Mar 15, 2024

What problem does this PR solve?

Issue Number: close #483

Problem Summary:
/api/admin/config doesn't respect Accept field in the request header, while some applications may expect a json format.

What is changed and how it works:
If Accept is json or format is json, return a json format.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- Support get JSON format config for /api/admin/config by setting Accept='application/json' in the request header

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox March 15, 2024 08:27
@ti-chi-bot ti-chi-bot bot added the size/L label Mar 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@5d2dfc2). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #484   +/-   ##
=======================================
  Coverage        ?   64.18%           
=======================================
  Files           ?       61           
  Lines           ?     5786           
  Branches        ?        0           
=======================================
  Hits            ?     3714           
  Misses          ?     1783           
  Partials        ?      289           
Flag Coverage Δ
unit 64.18% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

ti-chi-bot bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 15, 2024
Copy link

ti-chi-bot bot commented Mar 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-15 14:37:57.120019345 +0000 UTC m=+1041904.142265726: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Mar 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit 384e746 into pingcap:main Mar 15, 2024
5 checks passed
@djshow832 djshow832 deleted the config_json branch March 16, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/api/admin/config doesn't respect Content-Type
3 participants