Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend, metrics: add metrics for traffic and handshake #477

Merged
merged 4 commits into from
Mar 2, 2024

Conversation

djshow832
Copy link
Collaborator

@djshow832 djshow832 commented Feb 26, 2024

What problem does this PR solve?

Issue Number: close #406

Problem Summary:
We need metrics for traffic and handshake.

What is changed and how it works:
Add metrics for traffic and handshake.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

screenshot-20240229-181129
screenshot-20240229-181210

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- Add metrics for traffic and handshake.

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox February 26, 2024 03:24
@djshow832 djshow832 marked this pull request as draft February 26, 2024 03:24
@djshow832 djshow832 marked this pull request as ready for review February 29, 2024 10:14
@djshow832 djshow832 changed the title [DNM] backend, metrics: add metrics for traffic and handshake backend, metrics: add metrics for traffic and handshake Feb 29, 2024
@djshow832
Copy link
Collaborator Author

/retest

1 similar comment
@djshow832
Copy link
Collaborator Author

/retest

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 80.72289% with 16 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@3d80091). Click here to learn what that means.

Files Patch % Lines
pkg/proxy/backend/metrics.go 80.00% 6 Missing and 3 partials ⚠️
pkg/proxy/net/packetio.go 50.00% 4 Missing ⚠️
pkg/proxy/backend/backend_conn_mgr.go 88.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage        ?   64.24%           
=======================================
  Files           ?       61           
  Lines           ?     5761           
  Branches        ?        0           
=======================================
  Hits            ?     3701           
  Misses          ?     1772           
  Partials        ?      288           
Flag Coverage Δ
unit 64.24% <80.72%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djshow832
Copy link
Collaborator Author

/retest

Copy link

ti-chi-bot bot commented Mar 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 2, 2024
Copy link

ti-chi-bot bot commented Mar 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-02 13:05:35.886891064 +0000 UTC m=+1312824.634514160: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Mar 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 545822f into pingcap:main Mar 2, 2024
5 checks passed
@djshow832 djshow832 deleted the more_metrics branch March 4, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance metrics and logs
3 participants