Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: use a real proxy conn id #348

Merged
merged 2 commits into from
Aug 30, 2023
Merged

proxy: use a real proxy conn id #348

merged 2 commits into from
Aug 30, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Aug 25, 2023

What problem does this PR solve?

Issue Number: close #345

Problem Summary: Pass a real connection id.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot requested review from bb7133 and djshow832 August 25, 2023 02:47
@ti-chi-bot ti-chi-bot bot added the size/S label Aug 25, 2023
Copy link
Collaborator

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test to verify the conn ID changes

@djshow832
Copy link
Collaborator

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 29, 2023

@xhebox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-sequelize-test 2668341 link true /test pull-integration-sequelize-test
pull-integration-prisma-test 2668341 link true /test pull-integration-prisma-test
pull-integration-ruby-orm-test 2668341 link true /test pull-integration-ruby-orm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M and removed size/S labels Aug 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-30 06:25:46.305509206 +0000 UTC m=+1908310.854525190: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot merged commit efd29b1 into pingcap:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection id always 100
2 participants