Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add mysql client test #323

Merged
merged 41 commits into from
Jul 10, 2023
Merged

*: add mysql client test #323

merged 41 commits into from
Jul 10, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Jul 5, 2023 •
edited by djshow832
Loading

What problem does this PR solve?

Issue Number: close None

Problem Summary:

  • Add mysql client test.

What is changed and how it works:

  • Add mysql client test.
  • Support auth fast path to be compatible with mysql server 8.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

xhebox added 12 commits July 5, 2023 14:52
@xhebox
*: test
5bfa184 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
gg
85bc85b 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
a83ae3a 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
d4cd045 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
fedf2a5 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
51ff2d3 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
348ac48 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
3b85ed7 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
6a15003 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
dcfe2f7 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
ed48008 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
37100f5 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 July 5, 2023 08:30
@xhebox xhebox changed the title *: test *: add mysql client test Jul 5, 2023
xhebox added 16 commits July 5, 2023 16:43
@xhebox
fix
8778691 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
668a5f0 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
8a908c8 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
fb999c2 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
bf686ec 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
f1f7fd3 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
35c70c7 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
a65acde 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
35ea2e5 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
0190928 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
576721f 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
8e902b7 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
634f99d 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
855ce3a 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
b7ef303 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
945fe1e 
Signed-off-by: xhe <xw897002528@gmail.com>
xhebox added 10 commits July 6, 2023 15:50
@xhebox
fix
8a93f1a 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
c09d46d 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
1621ece 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
70f814e 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
98c8f32 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
f2e1271 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
deb4b6b 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix test
579f895 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix test
c452c29 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix test
cce74db 
Signed-off-by: xhe <xw897002528@gmail.com>
djshow832
djshow832 reviewed Jul 7, 2023
View reviewed changes
pkg/proxy/backend/authenticator.go Outdated Show resolved Hide resolved
pkg/manager/namespace/manager.go Show resolved Hide resolved
djshow832
djshow832 reviewed Jul 7, 2023
View reviewed changes
.github/workflows/integration.yml
Comment on lines +58 to +60
sed -i 's/# pd-addrs = "127.0.0.1:2379"/pd-addrs = ""/' conf/proxy.toml
sed -i 's/# auto-certs = true/auto-certs = true/' conf/proxy.toml
sed -i 's/4000/3306/' conf/namespace/example.toml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest creating another config files in the action. Do not rely on the content in conf/proxy.toml.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe later in tidb-test

djshow832
djshow832 reviewed Jul 10, 2023
View reviewed changes
pkg/proxy/backend/authenticator.go Outdated Show resolved Hide resolved
pkg/proxy/backend/authenticator.go Outdated Show resolved Hide resolved
xhebox and others added 3 commits July 10, 2023 11:13
@xhebox @djshow832
Update pkg/proxy/backend/authenticator.go
d1d6a90 
Co-authored-by: djshow832 <zhangming@pingcap.com>
@xhebox
reword
3cba500 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
Merge branch 'main' into test_1
3b43888
@djshow832 djshow832 merged commit 0c03603 into pingcap:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xhebox @djshow832