Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove more about tidb/parser/mysql #301

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Jun 2, 2023

What problem does this PR solve?

Issue Number: ref #248

Problem Summary: I hope there can be a single mysql package for mysql protocol parsing and serializing before we remove *PacketIO.

What is changed and how it works:

  1. Use more pnet.Capbility
  2. Use more pnet.AuthXX and pnet.XXXHeader

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xhebox xhebox requested a review from djshow832 June 2, 2023 07:41
pkg/proxy/net/packetio_mysql.go Outdated Show resolved Hide resolved
pkg/proxy/backend/mock_backend_test.go Outdated Show resolved Hide resolved
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 June 15, 2023 07:40
xhebox added 2 commits June 30, 2023 15:16
Signed-off-by: xhe <xw897002528@gmail.com>
@purelind
Copy link
Contributor

/test pull-mysql-connector-test

1 similar comment
@xhebox
Copy link
Collaborator Author

xhebox commented Jul 17, 2023

/test pull-mysql-connector-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 17, 2023

@xhebox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
wip/pull-mysql-connector-test bb924f4 link true /test pull-mysql-connector-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added the size/L label Jul 19, 2023
@xhebox
Copy link
Collaborator Author

xhebox commented Jul 20, 2023

/test pull-mysql-connector-test

1 similar comment
@xhebox
Copy link
Collaborator Author

xhebox commented Jul 20, 2023

/test pull-mysql-connector-test

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-28 07:04:29.16318451 +0000 UTC m=+510811.757715498: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot added the approved label Jul 28, 2023
@ti-chi-bot ti-chi-bot bot merged commit 81f4897 into pingcap:main Jul 28, 2023
@xhebox xhebox deleted the nbio_2 branch August 3, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants