Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: use atomic.Pointer for *signalRedirect #271

Merged
merged 4 commits into from
May 18, 2023
Merged

backend: use atomic.Pointer for *signalRedirect #271

merged 4 commits into from
May 18, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Apr 20, 2023

What problem does this PR solve?

Issue Number: ref #233

Problem Summary: Cleanup.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xhebox xhebox requested a review from djshow832 April 20, 2023 08:02
xhebox added 3 commits May 18, 2023 16:33
@xhebox
backend: use atomic.Pointer
b2906e8 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix test
8936814 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
remove IsRedirectable
fb06900 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
remove IsRedirectable
ab5c328 
Signed-off-by: xhe <xw897002528@gmail.com>
@djshow832 djshow832 merged commit 1538fcd into pingcap:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xhebox @djshow832