Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add more metrics and fix some metrics #261

Merged
merged 4 commits into from
Apr 6, 2023

Conversation

djshow832
Copy link
Collaborator

@djshow832 djshow832 commented Apr 4, 2023

What problem does this PR solve?

Issue Number: close #260

Problem Summary:
Currently, there are some problems of metrics:

  • The avg duration and get backend duration is wrong
  • We cannot inspect the latency from each tiproxy to each tidb, which may be affected by cross AZ network
  • Lack of metrics that used for alert

What is changed and how it works:

  • Fix avg duration and get backend duration
  • Add ping duration from each tiproxy to each tidb
  • Add server start event, load cert err, get backend fail counter, which are used for alert
  • Other experience optimization, such as add more legends, change OPM to counter, etc.

Alert rules will be added in another PR.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

backend
balance
query

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@djshow832 djshow832 requested a review from xhebox April 4, 2023 09:47
@djshow832 djshow832 marked this pull request as draft April 4, 2023 09:57
@djshow832 djshow832 marked this pull request as ready for review April 6, 2023 07:19
@djshow832 djshow832 merged commit 28ce2c6 into pingcap:main Apr 6, 2023
@djshow832 djshow832 deleted the add_metrics branch April 6, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more metrics
2 participants